Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(backend): Support totalCount on BAPI responses #2199

Merged
merged 1 commit into from
Nov 24, 2023

Conversation

dimkl
Copy link
Contributor

@dimkl dimkl commented Nov 23, 2023

Description

The backend clerkClient will return a totalCount: number in the responses for BAPI responses:

  • with total_count prop of response
  • with an array of objects as data prop of response

The totalCount is NOT included in:

  • single resource responses
  • error responses

Checklist

  • npm test runs as expected.
  • npm run build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

Packages affected

  • @clerk/backend
  • @clerk/chrome-extension
  • @clerk/clerk-js
  • @clerk/clerk-expo
  • @clerk/fastify
  • gatsby-plugin-clerk
  • @clerk/localizations
  • @clerk/nextjs
  • @clerk/clerk-react
  • @clerk/remix
  • @clerk/clerk-sdk-node
  • @clerk/shared
  • @clerk/themes
  • @clerk/types
  • build/tooling/chore

@dimkl dimkl self-assigned this Nov 23, 2023
Copy link

changeset-bot bot commented Nov 23, 2023

🦋 Changeset detected

Latest commit: ac9f633

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 6 packages
Name Type
@clerk/backend Minor
@clerk/fastify Patch
gatsby-plugin-clerk Patch
@clerk/nextjs Patch
@clerk/remix Patch
@clerk/clerk-sdk-node Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

The backend clerkClient will return a `totalCount: number`
in the responses for BAPI responses:
- with `total_count` prop of response
- with an array of objects as `data` prop of response

The `totalCount` is NOT included in:
- single resource responses
- error responses
@dimkl dimkl force-pushed the sdk-988-backend-total-count branch from b671a58 to ac9f633 Compare November 24, 2023 12:20
@dimkl dimkl added this pull request to the merge queue Nov 24, 2023
Merged via the queue into main with commit 0307957 Nov 24, 2023
7 checks passed
@dimkl dimkl deleted the sdk-988-backend-total-count branch November 24, 2023 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants